Increase secure session pool size to 4096 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the maximum amount of secure sessions to 4 times the device limit. This allows to have multiple sessions per device (if required) or multiple fabrics of up to 1024 devices. The size of a secure session is currently 264 bytes, so this will increase memory usage by about 1MB.
marcelveldt
reviewed
Jul 1, 2024
marcelveldt
reviewed
Jul 1, 2024
| @@ -59,6 +59,8 @@ | |||
| // Home Assistant Python Matter server specific configs | |||
| #define CHIP_EXCHANGE_NODE_ID_LOGGING 1 | |||
| #define CHIP_CONFIG_CONTROLLER_MAX_ACTIVE_DEVICES 1024 | |||
| #define CHIP_CONFIG_CONTROLLER_MAX_ACTIVE_CASE_CLIENTS 32 | |||
There was a problem hiding this comment.
what does this do ? as this feels a bit on the low side as well to me ?!
You almost think this should at least be max devices x 2
There was a problem hiding this comment.
This is "number of outgoing CASE sessions can be simutaneously negotiated". We currently setup 5 at a time at max, so this is quite a bit higher. But yeah maybe we can bump it a bit more too.
Co-authored-by: Marcel van der Veldt <m.vanderveldt@outlook.com>
marcelveldt
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the maximum amount of secure sessions to 4 times the device limit. This allows to have multiple sessions per device (if required) or multiple fabrics of up to 1024 devices.
The size of a secure session is currently 264 bytes, so this will increase memory usage by about 1MB.
While at it, also increase the number of outgoing CASE sessions can be simutaneously negotiated from the default 16 to 32 (
CHIP_CONFIG_CONTROLLER_MAX_ACTIVE_CASE_CLIENTS).