Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase secure session pool size to 4096 #88

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Increase secure session pool size to 4096 #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16d1879
Increase secure session pool size to 4096
agners Jul 1, 2024
5eec8c1
Update CHIPProjectConfig.h
agners Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHIPProjectConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
// Home Assistant Python Matter server specific configs
#define CHIP_EXCHANGE_NODE_ID_LOGGING 1
#define CHIP_CONFIG_CONTROLLER_MAX_ACTIVE_DEVICES 1024
#define CHIP_CONFIG_CONTROLLER_MAX_ACTIVE_CASE_CLIENTS 32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do ? as this feels a bit on the low side as well to me ?!
You almost think this should at least be max devices x 2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is "number of outgoing CASE sessions can be simutaneously negotiated". We currently setup 5 at a time at max, so this is quite a bit higher. But yeah maybe we can bump it a bit more too.

#define CHIP_CONFIG_MAX_EXCHANGE_CONTEXTS 192
#define CHIP_CONFIG_SECURE_SESSION_POOL_SIZE (CHIP_CONFIG_CONTROLLER_MAX_ACTIVE_DEVICES * 4)

#endif /* CHIPPROJECTCONFIG_H */