Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Python 3.11+ #784

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Require Python 3.11+ #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
474cc40
Run tests with Python 3.11
emontnemery Jan 16, 2024
e24c82b
Update setup.py
emontnemery Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:

steps:
- uses: actions/checkout@v4.1.1
- name: Set up Python 3.8
- name: Set up Python 3.11
uses: actions/setup-python@v5.0.0
with:
python-version: 3.8
python-version: 3.11
- name: Install dependencies
run: |
pip install -r requirements.txt
Expand Down
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pychromecast |Build Status|
.. |Build Status| image:: https://travis-ci.org/balloob/pychromecast.svg?branch=master
:target: https://travis-ci.org/balloob/pychromecast

Library for Python 3.6+ to communicate with the Google Chromecast. It
Library for Python 3.11+ to communicate with the Google Chromecast. It
currently supports:

- Auto discovering connected Chromecasts on the network
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
include_package_data=True,
platforms="any",
install_requires=list(val.strip() for val in open("requirements.txt")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: It's not good practice to set the production requirements the same way as the development requirements. I recommend pinning the development requirements strictly in requirements files (or an optional list in pyproject.toml) and have as forgiving pinning for the production as possible directly in setup.py (or pyproject.toml).

It would also be good to change to pyproject.toml at some point.

python_requires=">=3.11",
classifiers=[
"Intended Audience :: Developers",
"License :: OSI Approved :: MIT License",
Expand Down