Require Python 3.11+ #784
Merged
Require Python 3.11+ #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
requested changes
Jan 16, 2024
MartinHjelmare
approved these changes
Jan 16, 2024
| @@ -17,6 +17,7 @@ | |||
| include_package_data=True, | |||
| platforms="any", | |||
| install_requires=list(val.strip() for val in open("requirements.txt")), | |||
There was a problem hiding this comment.
Side note: It's not good practice to set the production requirements the same way as the development requirements. I recommend pinning the development requirements strictly in requirements files (or an optional list in pyproject.toml) and have as forgiving pinning for the production as possible directly in setup.py (or pyproject.toml).
It would also be good to change to pyproject.toml at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run tests with Python 3.11 and update Readme to mention Python 3.11+ is required