Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Wear Cleanup #1895

Merged
merged 7 commits into from Nov 10, 2021
Merged

Major Wear Cleanup #1895

merged 7 commits into from Nov 10, 2021

Conversation

JBassett
Copy link
Collaborator

Summary

This PR moves a bunch of stuff around. I tried to follow the Jetpack Compose guidelines and best practices.

Screenshots

No changes to actual look and feel

Link to pull request in Documentation repository

N/A

Any other notes

Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the debug APK, everything loads fine with the exception that favorites no longer loads during the loading screen. A better way to handle this is to store things in a DB rather than local storage. In a future PR maybe we can temporarily add that call back until we get Room setup once #1890 is merged?

@JBassett JBassett merged commit 4fdbe72 into master Nov 10, 2021
@JBassett JBassett deleted the feature/wearCleanup branch November 10, 2021 14:35
@JBassett
Copy link
Collaborator Author

Took a look at the debug APK, everything loads fine with the exception that favorites no longer loads during the loading screen. A better way to handle this is to store things in a DB rather than local storage. In a future PR maybe we can temporarily add that call back until we get Room setup once #1890 is merged?

I do think we can create a temporary Entity for the favorites that we pass into the EntityUi for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants