Clean up welcome and notification details compose views #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBassett
requested changes
Nov 11, 2021
Comment on lines
34
to
36
| val notificationItem = rememberSaveable { | ||
| NotificationData(notification.received, notification.message, notification.data) | ||
| } |
There was a problem hiding this comment.
So I'm not sure we need the rememberSaveable here?
There was a problem hiding this comment.
rememberSaveable will retain when the UI is redrawn like when the orientation changes.
https://developer.android.com/jetpack/compose/state#restore-ui-state
I think I added this in the first PR we made to pass in the state? I can remove it if you like
There was a problem hiding this comment.
You only need the remember and rememberSavable if the state only exists inside the compose function. Since the data is coming from outside the compose function we don't need to save it there.
JBassett
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Start to use better compose methods to follow along with #1895
Also adds preview for notification details
Also adding a vertical scroll modifier to the columns in case the screen is small
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes