Use enum for sensor setting type #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
force-pushed
the
sensor-manager-enum
branch
3 times, most recently
from
59fa9d6
to
5dc6b91
Compare
JBassett
approved these changes
Apr 23, 2022
NotWoods
force-pushed
the
sensor-manager-enum
branch
from
5dc6b91
to
0635244
Compare
|
I think this PR may have changed how sensor settings behave in the app, now every setting is a text field instead of being things like a toggle or a list or even a numeric field. For toggles we now have to type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving off a string type to a strict enum, since there are only certain valid values. Added a type converter to Room so this should be backwards compatible.