Fix sensor setting type converter #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "a === b evaluates to true if and only if a and b point to the same object", which will never be true for a String, so change it to a == b instead https://kotlinlang.org/docs/equality.html#referential-equality
JBassett
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2469 introduced a bug which resulted in sensor settings always being considered of the type
STRINGwhen read from the database because===was used in the type converter. It looks like there is some magic in the database that breaks this comparison for strings, so only compare the contents instead.Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes