Fix global vars in bedtime and theater mode #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Thanks for fixing the doc links!
I think its safe to assume that the galaxy watch 5 will use the same globals as the galaxy watch 4. Its also "safe" to consider the Pixel Watch as a reference device here so its good to default to it. Hopefully the other Wear OS devices use the same variables.
JBassett
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a check in the Theater & Bedtime mode sensors for Samsung(assuming the GW5 uses the same) as they have different globals for those. Also changes the location the documentation URLs point to.
Screenshots
Link to pull request in Documentation repository
Documentation: N/A
Any other notes