Update/replace deprecations in app module #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
approved these changes
Jul 15, 2023
|
And it's not even all of them 😄 |
JBassett
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update a lot of code marked as deprecated in the
appmodule to the new, non-deprecated alternative. and/or update annotation to ignore. This should clean up the number of warnings during a build.Did a quick test of functionality on an up-to-date Android 13 device and an older version, everything appears to work as expected.
Two major deprecations are not handled in this PR as it is already quite large:
onCreateOptionsMenu/onPrepareOptionsMenu/onOptionsItemSelected->MenuProviderScreenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes