ListHeader: fix text cut off #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set overflow for ListHeader to ellipsis instead of cutting of text - Set the maximum number of lines for ListHeader based on the font size - Center text in the list header for nicer appearance in case of multiple ines
dshokouhi
approved these changes
Sep 28, 2023
JBassett
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent text from being cut off abruptly in the
ListHeaders used in the app (on almost every screen) by calculating the number of lines that fit based on text size + overflow with ellipsis + centering text.Screenshots
Link to pull request in Documentation repository
n/a
Any other notes