Adding new sensor classes - speed, mass, direction, distance and level #605
-
I did a PR with a set of new sensor classes but realised that there is a need for architectural discussion first. home-assistant/core#54605. In the PR I added:
But now PM1, 2.5 and 10 are moving in via another PR. MASS in a previous PR that was very close to being merged (from what I understood). What I would like to do with Home assistant - that is reason for this - is to add complete air quality measuring (maybe we should add RADON also - for Airthings sensors) and add a weather station with wind speed and wind direction. And after having a feature request vote out I got some other suggestions so I decided to make a PR (but failed to do this discussion before). I am happy to cut-down the PR a bit if some of the sensor classes feel uninteresting or unlikely to be supported by any device - or adapt it in other ways that would be required. BTW: is there any efforts on refactoring the sensor class model? It feels like there is a lot of repetition of sensor-class lists and constants spread over many files in all the PR:s? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 3 replies
-
We should split this into different topics, which we can discuss individually. Additionally, mass, frequency, mass, and particulate matter already have topics, thus should not be part of this proposal. |
Beta Was this translation helpful? Give feedback.
We should split this into different topics, which we can discuss individually. Additionally, mass, frequency, mass, and particulate matter already have topics, thus should not be part of this proposal.