Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HACS Sunpower integration #3134

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Conversation

jeeftor
Copy link
Contributor

@jeeftor jeeftor commented Feb 3, 2022

Proposed change

Creating a custom icon for: https://github.com/krbaker/hass-sunpower

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo has quite a lot of white/transparent space around it, can we trim that down?

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Feb 4, 2022
@jeeftor
Copy link
Contributor Author

jeeftor commented Feb 4, 2022

The logo has quite a lot of white/transparent space around it, can we trim that down?

It just went on a diet! (Extra white has been reduced...)

@jeeftor
Copy link
Contributor Author

jeeftor commented Feb 15, 2022

Hoping to get this re-reviewd at some point :) (wasn't sure if there was a button I can push)

@frenck
Copy link
Member

frenck commented Feb 15, 2022

Oh I'm sorry 🙏
I haven't noticed it was ready.

Nevertheless, the images are still the same size and not trimmed down.

@jeeftor
Copy link
Contributor Author

jeeftor commented Feb 15, 2022

New Logo Sizes:

dark_logo.png PNG 256x128 256x128+0+0 8-bit sRGB 8402B 0.010u 0:00.004
dark_logo@2x.png PNG 512x256 512x256+0+0 8-bit sRGB 16525B 0.000u 0:00.000
logo.png PNG 256x128 256x128+0+0 8-bit sRGB 6341B 0.010u 0:00.000
logo@2x.png PNG 512x256 512x256+0+0 8-bit sRGB 11757B 0.000u 0:00.000

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jeeftor 👍

@frenck frenck merged commit 9474364 into home-assistant:master Feb 16, 2022
KartoffelToby pushed a commit to KartoffelToby/brands that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed in-progress This PR/Issue is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants