Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RESOL icon/logos for custom integration for Resol KM2 controller #4904

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

evercape
Copy link
Contributor

@evercape evercape commented Nov 15, 2023

Adding icons for custom Resol Controller integration

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@evercape
Copy link
Contributor Author

Here is the link to the custom_integration which I would like to add to HACS, however, require the brands logos to be updated:

https://github.com/evercape/hass-resol-KM2/

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evercape 👍

../Frenck

@frenck frenck merged commit 86cebd9 into home-assistant:master Nov 20, 2023
5 checks passed
@evercape
Copy link
Contributor Author

Thanks @frenck much appreciated

First time for me doing this - can you pls let me know although you approved and closed the PR, why are the logos still showing a 404?

https://brands.home-assistant.io/resol/icon.png

Thanks,
Martin

@frenck
Copy link
Member

frenck commented Nov 20, 2023

First time for me doing this - can you pls let me know although you approved and closed the PR, why are the logos still showing a 404?

Cache @ CloudFlare, it takes time to expire. We flush the cache fully on each major Home Assistant release.

../Frenck

@evercape
Copy link
Contributor Author

Cache @ CloudFlare, it takes time to expire. We flush the cache fully on each major Home Assistant release.

Thx, makes sense. Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants