Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink traccar as traccar_server #5141

Merged
merged 1 commit into from Jan 31, 2024
Merged

Symlink traccar as traccar_server #5141

merged 1 commit into from Jan 31, 2024

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Jan 28, 2024

Proposed change

For home-assistant/core#109002

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use a brands definition instead?

@frenck frenck added the has-parent This PR has a parent PR in a other repo label Jan 28, 2024
@ludeeus
Copy link
Member Author

ludeeus commented Jan 28, 2024

Eventually, yes, however...
The current client icon is wrong, and the brand does not yet exist in core, nor does a PR to add it (scope limitations)

@frenck frenck merged commit 241590f into master Jan 31, 2024
6 checks passed
@frenck frenck deleted the traccar_server branch January 31, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants