Skip to content

Commit

Permalink
Follow up comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jbouwh committed Aug 23, 2023
1 parent 291ce97 commit 2b396c0
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions homeassistant/components/mqtt/discovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,24 +110,24 @@ def set_discovery_hash(hass: HomeAssistant, discovery_hash: tuple[str, str]) ->


@callback
def async_log_integration_discovery_info(
def async_log_discovery_origin_info(
message: str, discovery_payload: MQTTDiscoveryPayload
) -> None:
"""Log information about the entity."""
"""Log information about the discovery and origin."""
if CONF_ORIGIN not in discovery_payload:
_LOGGER.info(message)
return
integration_info: MqttOriginInfo = discovery_payload[CONF_ORIGIN]
origin_info: MqttOriginInfo = discovery_payload[CONF_ORIGIN]
sw_version_log = ""
if sw_version := integration_info.get("sw_version"):
if sw_version := origin_info.get("sw_version"):
sw_version_log = f", version: {sw_version}"
support_url_log = ""
if support_url := integration_info.get("support_url"):
if support_url := origin_info.get("support_url"):
support_url_log = f", support URL: {support_url}"
_LOGGER.info(
"%s from external application %s%s%s",
message,
integration_info["name"],
origin_info["name"],
sw_version_log,
support_url_log,
)
Expand Down Expand Up @@ -189,12 +189,12 @@ def async_discovery_message_received(msg: ReceiveMessage) -> None: # noqa: C901
device[key] = device.pop(abbreviated_key)

if CONF_ORIGIN in discovery_payload:
integration_info: dict[str, Any] = discovery_payload[CONF_ORIGIN]
origin_info: dict[str, Any] = discovery_payload[CONF_ORIGIN]
try:
for key in list(integration_info):
for key in list(origin_info):
abbreviated_key = key
key = ORIGIN_ABBREVIATIONS.get(key, key)
integration_info[key] = integration_info.pop(abbreviated_key)
origin_info[key] = origin_info.pop(abbreviated_key)
MQTT_ORIGIN_INFO_SCHEMA(discovery_payload[CONF_ORIGIN])
except Exception: # pylint: disable=broad-except
_LOGGER.warning(
Expand Down Expand Up @@ -302,14 +302,14 @@ def discovery_done(_: Any) -> None:
if discovery_hash in mqtt_data.discovery_already_discovered:
# Dispatch update
message = f"Component has already been discovered: {component} {discovery_id}, sending update"
async_log_integration_discovery_info(message, payload)
async_log_discovery_origin_info(message, payload)
async_dispatcher_send(
hass, MQTT_DISCOVERY_UPDATED.format(discovery_hash), payload
)
elif payload:
# Add component
message = f"Found new component: {component} {discovery_id}"
async_log_integration_discovery_info(message, payload)
async_log_discovery_origin_info(message, payload)
mqtt_data.discovery_already_discovered.add(discovery_hash)
async_dispatcher_send(
hass, MQTT_DISCOVERY_NEW.format(component, "mqtt"), payload
Expand Down

0 comments on commit 2b396c0

Please sign in to comment.