Skip to content

Commit

Permalink
Fix issue with Insteon linked devices maintaining current state (#94286)
Browse files Browse the repository at this point in the history
* Bump pyinsteon

* Update tests
  • Loading branch information
teharris1 committed Jun 11, 2023
1 parent 3cf2c81 commit 3eedbe9
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion homeassistant/components/insteon/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"iot_class": "local_push",
"loggers": ["pyinsteon", "pypubsub"],
"requirements": [
"pyinsteon==1.4.2",
"pyinsteon==1.4.3",
"insteon-frontend-home-assistant==0.3.5"
],
"usb": [
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1724,7 +1724,7 @@ pyialarm==2.2.0
pyicloud==1.0.0

# homeassistant.components.insteon
pyinsteon==1.4.2
pyinsteon==1.4.3

# homeassistant.components.intesishome
pyintesishome==1.8.0
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_all.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ pyialarm==2.2.0
pyicloud==1.0.0

# homeassistant.components.insteon
pyinsteon==1.4.2
pyinsteon==1.4.3

# homeassistant.components.ipma
pyipma==3.0.6
Expand Down
4 changes: 2 additions & 2 deletions tests/components/insteon/mock_devices.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,11 @@ def fill_properties(self, address, props_dict):
for flag in operating_flags:
value = operating_flags[flag]
if device.operating_flags.get(flag):
device.operating_flags[flag].load(value)
device.operating_flags[flag].set_value(value)
for flag in properties:
value = properties[flag]
if device.properties.get(flag):
device.properties[flag].load(value)
device.properties[flag].set_value(value)

async def async_add_device(self, address=None, multiple=False):
"""Mock the async_add_device method."""
Expand Down
4 changes: 2 additions & 2 deletions tests/components/insteon/test_api_properties.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ async def test_get_read_only_properties(
mock_read_only = ExtendedProperty(
"44.44.44", "mock_read_only", bool, is_read_only=True
)
mock_read_only.load(False)
mock_read_only.set_value(False)

ws_client, devices = await _setup(
hass, hass_ws_client, "44.44.44", iolinc_properties_data
Expand Down Expand Up @@ -368,7 +368,7 @@ async def test_change_float_property(
)
device = devices["44.44.44"]
delay_prop = device.configuration[MOMENTARY_DELAY]
delay_prop.load(0)
delay_prop.set_value(0)
with patch.object(insteon.api.properties, "devices", devices):
await ws_client.send_json(
{
Expand Down

0 comments on commit 3eedbe9

Please sign in to comment.