Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Insteon linked devices maintaining current state #94286

Merged
merged 2 commits into from Jun 11, 2023

Conversation

teharris1
Copy link
Contributor

@teharris1 teharris1 commented Jun 8, 2023

Proposed change

Fix an issue where two or more Insteon devices are linked and some network communications are dropped, the state of the child devices are not always updated in HA.

This change bumps the pyinsteon dependency to 1.4.3 from 1.4.2.

Change log: pyinsteon/pyinsteon@1.4.2...1.4.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@teharris1 teharris1 added this to the 2023.6.2 milestone Jun 8, 2023
Copy link
Contributor

@jkeljo jkeljo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it matters, but "dependency upgrade" is probably a better category for this than "bugfix". Looks like all the cow changes in the integration itself were forced by a method name changing in the new version of the dependency.

@balloob balloob merged commit 3eedbe9 into home-assistant:dev Jun 11, 2023
52 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
@teharris1 teharris1 deleted the fix_device_status branch January 3, 2024 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants