Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jewish Calendar Daylight Savings offset? #23032

Closed
theChef613 opened this issue Apr 12, 2019 · 7 comments · Fixed by #25726
Closed

Jewish Calendar Daylight Savings offset? #23032

theChef613 opened this issue Apr 12, 2019 · 7 comments · Fixed by #25726
Labels
integration: jewish_calendar

Comments

@theChef613
Copy link

theChef613 commented Apr 12, 2019 •
edited by MartinHjelmare

Hello,
The Issur Melacha in Effect boolean has been off by an hour ever since daylight savings started. The portion that deals with adding the Jewish calendar is as follows:

sensor:
  - platform: jewish_calendar
    language: english
    diaspora: true
    candle_lighting_minutes_before_sunset: 30
    havdalah_minutes_after_sunset: 45
    sensors:
      - date
      - weekly_portion
      - upcoming_candle_lighting
      - upcoming_havdalah
      - issur_melacha_in_effect

Also, I live in LA if that helps.
@github-actions
Copy link

Hey there @tsvi, mind taking a look at this issue as its been labeled with a integration (jewish_calendar) you are listed as a codeowner for? Thanks!

@ac2323
Copy link

ac2323 commented Apr 12, 2019

I'm having the same issue.

@theChef613
Copy link
Author

Hello,
Any update on this? Thank you!

@tsvi
Copy link
Contributor

tsvi commented May 20, 2019

Sorry for not commenting earlier. I'm working on a bugfix.
Once I have a patch ready I'll hopefully add it here as a custom component so you don't need to wait for the release.

@theChef613
Copy link
Author

that's great! thank you!

@theChef613
Copy link
Author

hello! I was wondering if there has been any further update on this? I've been using another sensor from the community but that seems to be broken lately too.. :(

@mikeage
Copy link
Contributor

mikeage commented Jun 23, 2019

Mine seems off, but not by an hour. It seems like it might be looking at shkia instead of tzeis for ending times (not sure about the start time)

@tsvi tsvi mentioned this issue Jul 1, 2019
Merged
@theChef613 theChef613 mentioned this issue Jul 4, 2019
Closed
tsvi added a commit to tsvi/home-assistant that referenced this issue Aug 6, 2019
@tsvi
Bump hdate==0.9.0 (use pytz instead of dateutil)
92c5246 
Use new hdate version of library which uses pytz for timezones.
dateutil expects /usr/share/timezone files, as these are not available
in the docker image and in HASSIO, the timezone offsets are broken.

This should fix
 - home-assistant#23032
 - home-assistant#18731
@tsvi tsvi mentioned this issue Aug 6, 2019
Merged
9 tasks
andrewsayre pushed a commit that referenced this issue Aug 6, 2019
@tsvi @andrewsayre
Bump hdate==0.9.0 (use pytz instead of dateutil) (#25726)
54d6acf 
Use new hdate version of library which uses pytz for timezones.
dateutil expects /usr/share/timezone files, as these are not available
in the docker image and in HASSIO, the timezone offsets are broken.

This should fix
 - #23032
 - #18731
balloob pushed a commit that referenced this issue Aug 7, 2019
@tsvi @balloob
Bump hdate==0.9.0 (use pytz instead of dateutil) (#25726)
3a78250 
Use new hdate version of library which uses pytz for timezones.
dateutil expects /usr/share/timezone files, as these are not available
in the docker image and in HASSIO, the timezone offsets are broken.

This should fix
 - #23032
 - #18731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integration: jewish_calendar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump hdate==0.9.0 (use pytz instead of dateutil) tsvi/home-assistant
5 participants
@mikeage @tsvi @theChef613 @ludeeus @ac2323