Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please pull latest Github master for youtube-dl to fix YouTube Shorts #73128

Closed
danswett opened this issue Jun 6, 2022 · 7 comments
Closed

Comments

@danswett
Copy link

danswett commented Jun 6, 2022

The problem

Trying to use media_extractor on a YouTube Shorts URL fails with an "unable to recognize tab page" error. This was fixed in yt-dl and merged in February, but the issue persists in the media_extractor in Home Assistant.

ytdl-org/youtube-dl#30269
ytdl-org/youtube-dl#30626 (comment)

Examples of logs from my HA instance:
Logger: homeassistant.components.media_extractor
Source: /usr/local/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py:526
Integration: media_extractor (documentation, issues)
First occurred: June 5, 2022, 9:57:46 PM (6 occurrences)
Last logged: June 5, 2022, 10:05:13 PM

ERROR: Unable to recognize tab page; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

What version of Home Assistant Core has the issue?

2022.6.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@probot-home-assistant
Copy link

media_extractor documentation
media_extractor source
(message by IssueLinks)

@danswett
Copy link
Author

danswett commented Jun 7, 2022

Going back and forth with the owner of the youtube-dl repo. Seems like he fixed this after the latest official release which is the version currently pinned in HA Core (2021.12.17).

I've asked if there's a timeline for another "official" release as I assume the HA core folks won't be super keen to move off the "official" release RE: potential risk.

@frenck
Copy link
Member

frenck commented Jun 7, 2022

Home Assistant can't work with branches and needs releases published on Pypi.

@danswett
Copy link
Author

It's not completed - this still doesn't work.

@frenck
Copy link
Member

frenck commented Jul 16, 2022

It's not completed - this still doesn't work.

We can't make it work more, it depends on upstream changes/release. We are at the latest version possible. See also comments above.

@chpego
Copy link
Contributor

chpego commented Jul 29, 2022

Why not using the yt-dlp project fork instead of youtube-dl in media_extractor component ?
I made a copy of the component in the custom folder, modifying the associated lines; it seems to work

@frenck
Copy link
Member

frenck commented Jul 29, 2022

Feel free to contribute changes or fixes, this is an open-source project. 👍

@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants