New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youtube shorts URL causes "unable to recognize tab page" error #30269
Comments
i know there are workarounds but for a program called "youtube-dl" I feel like it should work for all youtube links |
well then its a convenience i think it should have |
It doesn't seem unreasonable, but it's a simple change:
|
facing the same issue on my website savetube, any solution? |
If you can parse out the ID of the video you can just pass that to YouTube-dl The fork yt-dlp has this fixed if you don't feel like doing that and want some extra features |
Or just apply the patch that was posted ... |
Modifying libraries in use can be a pain and if managed by pip or similar changes can be overwritten. Yes they could make a pull and implement the change but that's a big hassle |
The poster has a website, where applying a 1-line patch to free software should be the least problem. A production system with live updates from a package repository deserves any breakage that will occur. As you suggest, anyone manually downloading would normally find it easier just to pass the ID instead. Generally, a statement that package Y solves a problem with yt-dl isn't helpful, particularly when package Y is already well discussed in other issues, rather than, say, offering to maintain a new release. |
I had no intention do to that. I was expecting their work to make it into the project via a pull. I wasn't specifically talking about this patch, I just thought that modifying libraries directly in general wasn't best practice. Wrongly so apparently, so I apologize. |
Feel free to submit a PR, though this project is seemingly abandoned by @dstftw for the indefinite future. |
Ah |
Thanks for the above tip, and the patch. |
Checklist
Verbose log
Description
the "share" button on youtube shorts can generate a URL in the following format:
https://youtube.com/shorts/[videoid]?feature=share
. this causes the above error. reformatting the URL to the typicalhttps://youtube.com/watch?v=[videoid]
works fine.The text was updated successfully, but these errors were encountered: