Improve Ikea Idasen config flow error messages #101567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
Hacktoberfest
integration: idasen_desk
new-feature
small-pr
frenck
requested changes
Oct 7, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
abmantis
force-pushed
the
idasen_better_flow_errors
branch
from
2a88370
to
9d1d60e
Compare
|
I think this could also go into a point release for the current one, as we got quite a few user report just in the first days after release. |
frenck
approved these changes
Oct 7, 2023
| @@ -64,6 +64,9 @@ async def async_step_user( | |||
| desk = Desk(None) | |||
| try: | |||
| await desk.connect(discovery_info.device, monitor_height=False) | |||
| except AuthFailedError as err: | |||
| _LOGGER.exception("AuthFailedError", exc_info=err) | |||
There was a problem hiding this comment.
Using both the exception logging method and exc_info isn't needed.
We normally don't log the stack trace if the exception is known.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
There are a few issues with bleak with bluez, that don't manifest when using ESPHome BT Proxy.
One of them is the lack of an agent on bleak (hbldh/bleak#1434)
which is already mentioned on the docs (home-assistant/home-assistant.io#29207).
With ESPHome, it works.
Another difference is that when using ESPHome BT Proxy, the desk pairs even if it is not
in pairing mode anymore, while this does not happen with bleak/bluez.
Also, bleak/bluez fails to connect a lot more often than ESPHome.
Diff for dependecy update: abmantis/idasen-ha@1.4...1.4.1
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: