Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for family to aiohttp session helper #102702

Merged
merged 3 commits into from Oct 24, 2023
Merged

Add support for family to aiohttp session helper #102702

merged 3 commits into from Oct 24, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 24, 2023

Proposed change

needed for #98003 since we don't want to implement this manually (anywhere if possible since its very easy to get wrong), and its likely we will need more combinations in the future

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @bdraco 👍

@bdraco
Copy link
Member Author

bdraco commented Oct 24, 2023

Thanks. Will kick the CI later when the rate limit goes back down

@bdraco bdraco marked this pull request as ready for review October 24, 2023 21:57
@bdraco bdraco requested a review from a team as a code owner October 24, 2023 21:57
@bdraco bdraco merged commit f91583a into dev Oct 24, 2023
53 checks passed
@bdraco bdraco deleted the aiohttp_family branch October 24, 2023 23:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants