Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable IPV6 in the august integration #98003

Merged
merged 3 commits into from Oct 25, 2023
Merged

Disable IPV6 in the august integration #98003

merged 3 commits into from Oct 25, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 7, 2023

Proposed change

fixes #97146 fixes #71610

This problem keeps coming up over and over again and its likely aio-libs/aiohttp#4451 will not be solved anytime soon

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

fixes #97146

This problem keeps coming up over and over again and
its likely aio-libs/aiohttp#4451 will
not be solved anytime soon
@bdraco
Copy link
Member Author

bdraco commented Aug 7, 2023

This won't work because the arg isn't passed down far enough to the connector

@bdraco bdraco closed this Aug 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2023
@bdraco bdraco reopened this Oct 24, 2023
@home-assistant home-assistant unlocked this conversation Oct 24, 2023
bdraco added a commit that referenced this pull request Oct 24, 2023
@bdraco bdraco marked this pull request as ready for review October 24, 2023 23:57
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Oct 25, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit ece7ec6 into dev Oct 25, 2023
23 checks passed
@frenck frenck deleted the ipv6_august branch October 25, 2023 04:08
@bdraco
Copy link
Member Author

bdraco commented Oct 25, 2023

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed integration: august Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
2 participants