Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geniushub-client to v0.7.1 #103071

Merged
merged 1 commit into from Oct 31, 2023
Merged

Conversation

manzanotti
Copy link
Contributor

@manzanotti manzanotti commented Oct 30, 2023

Proposed change

Update the GeniusHub client library. Contains a fix for #94006

Changelog: manzanotti/geniushub-client@v0.7.0...v0.7.1
Documentaion of the change: https://github.com/manzanotti/geniushub-client/releases/tag/v0.7.1

Most of the changes in that update relate to github workflows.

The only code fix is from this pull request: manzanotti/geniushub-client#79

Type of change

  • [x ] Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • [ x] The code change is tested and works locally.
  • [ x] Local tests pass. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • [ x] I have followed the development checklist
  • [ x] I have followed the perfect PR recommendations
  • [ x] The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

home-assistant[bot]

This comment was marked as outdated.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @manzanotti

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@manzanotti manzanotti marked this pull request as ready for review October 30, 2023 15:08
@home-assistant home-assistant bot dismissed stale reviews from themself October 30, 2023 15:08

Stale

@MartinHjelmare MartinHjelmare changed the title Update client package to v0.7.1 Update geniushub-client to v0.7.1 Oct 30, 2023
frenck
frenck previously requested changes Oct 30, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Additionally, the CI is failing, indicating you have not updated/created this PR using the development environment as documented in our developer documentation (and thus most likely also hasn't been tested in a developer environment). Please be sure to test it using a dev environment and fix the CI error before marking this PR ready for review.

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft October 30, 2023 17:37
@manzanotti manzanotti force-pushed the UpdateTo0.7.1 branch 2 times, most recently from 035e242 to 7bbc975 Compare October 30, 2023 17:47
@manzanotti manzanotti marked this pull request as ready for review October 30, 2023 17:49
@manzanotti
Copy link
Contributor Author

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Additionally, the CI is failing, indicating you have not updated/created this PR using the development environment as documented in our developer documentation (and thus most likely also hasn't been tested in a developer environment). Please be sure to test it using a dev environment and fix the CI error before marking this PR ready for review.

Thanks already! 👍

Apologies, my first PR here, and managed to mess up my commit.

Links added to the PR, as well as the updated requirements file.

@frenck frenck added this to the 2023.11.0 milestone Oct 30, 2023
@frenck
Copy link
Member

frenck commented Oct 30, 2023

Apologies, my first PR here, and managed to mess up my commit.

No worries! Thanks for being willing to contribute! ❤️

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manzanotti 👍

@edenhaus edenhaus merged commit 06bbea2 into home-assistant:dev Oct 31, 2023
53 checks passed
frenck pushed a commit that referenced this pull request Oct 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genius hub not working
4 participants