New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update geniushub-client to v0.7.1 #103071
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
4f04a3f
to
b63bd61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @manzanotti
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Additionally, the CI is failing, indicating you have not updated/created this PR using the development environment as documented in our developer documentation (and thus most likely also hasn't been tested in a developer environment). Please be sure to test it using a dev environment and fix the CI error before marking this PR ready for review.
Thanks already! 👍
035e242
to
7bbc975
Compare
7bbc975
to
4756e2e
Compare
Apologies, my first PR here, and managed to mess up my commit. Links added to the PR, as well as the updated requirements file. |
No worries! Thanks for being willing to contribute! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manzanotti 👍
Proposed change
Update the GeniusHub client library. Contains a fix for #94006
Changelog: manzanotti/geniushub-client@v0.7.0...v0.7.1
Documentaion of the change: https://github.com/manzanotti/geniushub-client/releases/tag/v0.7.1
Most of the changes in that update relate to github workflows.
The only code fix is from this pull request: manzanotti/geniushub-client#79
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: