Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with unknown devices or errors are now handled #79

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

manzanotti
Copy link
Owner

This replaces #78.

Unknown issues and devices are now handled by the code.

Move the issue code out into its own class, matching the future direction of the codebase.

Added tests to cover issues.

@manzanotti
Copy link
Owner Author

@GeoffAtHome Do you want to cast an eye over this commit, make sure it makes sense to you?

Copy link
Contributor

@GeoffAtHome GeoffAtHome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Paul,

Like the refactoring. Splitting the issues out to a new file gets my vote as does the changes to parsing arguments.

Still works on my system so I am pleased.

@manzanotti
Copy link
Owner Author

Hi Paul,

Like the refactoring. Splitting the issues out to a new file gets my vote as does the changes to parsing arguments.

Still works on my system so I am pleased.

Yeah, I first started splitting the code up into more class-based units three (!) years ago, though I didn't end up merging it in as it felt like too big a change. I ended up just adding tests for the current code base first. I still plan to move to that model though.

You can see the changes in the old PRs:

https://github.com/manzanotti/geniushub-client/pull/48/files
https://github.com/manzanotti/geniushub-client/pull/49/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants