Add height sensor to Idasen Desk integration #103324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: J. Nick Koston <nick@koston.org>
gjohansson-ST
requested changes
Nov 3, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
bdraco
reviewed
Nov 4, 2023
gjohansson-ST
previously requested changes
Nov 6, 2023
bdraco
approved these changes
Nov 13, 2023
|
@abmantis It looks like this is good to go once there is a docs PR linked |
|
Needs rebase to resolve conflicts and a doc PR needs to be made. |
8 tasks
|
Docs PR added and conflicts resolved. |
bdraco
approved these changes
Nov 20, 2023
gjohansson-ST
approved these changes
Nov 20, 2023
| async def async_added_to_hass(self) -> None: | ||
| """When entity is added to hass.""" | ||
| await super().async_added_to_hass() | ||
| self._handle_coordinator_update() |
There was a problem hiding this comment.
This will make an extra state update besides the default state update at the end of entity addition. We should separate the native value attribute update from the state update if we need to update the native value here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This exposes the height in meters from the desk. This is more granular than the
percentage offered by the cover platform, allowing the user to detect even small
desk changes from the physical controller.
One use case mentioned in abmantis/idasen-ha#14
is being able to use a double press on the physical controller to trigger an automation
on Home Assistant, like moving the desk to a pre-defined position.
idasen-ha lib update changelog: abmantis/idasen-ha@2.3...2.4
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: