Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reauth support to Schlage #103351

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Conversation

dknowles2
Copy link
Contributor

Proposed change

Add support for reauthentication to the Schlage integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@dknowles2 dknowles2 requested a review from bdraco November 4, 2023 14:42
@dknowles2 dknowles2 marked this pull request as ready for review November 4, 2023 14:42
@bdraco
Copy link
Member

bdraco commented Nov 4, 2023

Thanks @dknowles2

@home-assistant home-assistant bot marked this pull request as draft November 4, 2023 15:33
@home-assistant
Copy link

home-assistant bot commented Nov 4, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dknowles2 dknowles2 marked this pull request as ready for review November 4, 2023 16:21
@home-assistant home-assistant bot marked this pull request as draft November 4, 2023 18:35
@dknowles2 dknowles2 marked this pull request as ready for review November 4, 2023 23:09
@home-assistant home-assistant bot marked this pull request as draft November 6, 2023 00:26
@dknowles2 dknowles2 marked this pull request as ready for review November 6, 2023 13:29
@sdb9696 sdb9696 mentioned this pull request Nov 10, 2023
20 tasks
@dknowles2
Copy link
Contributor Author

All comments addressed 👍🏻

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last piece

homeassistant/components/schlage/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 15, 2023 12:31
@dknowles2 dknowles2 marked this pull request as ready for review November 15, 2023 23:47
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dknowles2 👍

@gjohansson-ST gjohansson-ST merged commit e10c524 into home-assistant:dev Nov 16, 2023
23 checks passed
@dknowles2 dknowles2 deleted the schlage-reauth branch November 17, 2023 01:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants