Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for play/pause functionality in System Bridge #103423

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Nov 5, 2023

Proposed change

Fixes use of play/pause service for System Bridge media player.

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@jkklemm jkklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes would disable the config. Is it not a better way to enable both entries via a config. Another way is to add the feature play if pause or stop is enabled and start is not enabled.

@timmo001
Copy link
Contributor Author

timmo001 commented Nov 5, 2023

This changes would disable the config. Is it not a better way to enable both entries via a config. Another way is to add the feature play if pause or stop is enabled and start is not enabled.

Not sure what you mean here? Disable what config?

@timmo001 timmo001 changed the title Fix support for play/pause functionality Fix support for play/pause functionality in System Bridge Nov 5, 2023
@jkklemm
Copy link

jkklemm commented Nov 5, 2023

Not sure what you mean here? Disable what config?

The values is_pause_enabled and is_play_enabled are loaded via a configuration file, isn't that right? Then, why are they not set correctly in the configuration file?

@timmo001
Copy link
Contributor Author

timmo001 commented Nov 5, 2023

Not sure what you mean here? Disable what config?

The values is_pause_enabled and is_play_enabled are loaded via a configuration file, isn't that right? Then, why are they not set correctly in the configuration file?

These come from the websocket reporting if these are enabled so when no media is active, these features won't be enabled

Copy link

github-actions bot commented Jan 6, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Jan 6, 2024
@joostlek joostlek added this to the 2024.1.2 milestone Jan 6, 2024
@joostlek joostlek merged commit ba60290 into home-assistant:dev Jan 6, 2024
23 checks passed
frenck pushed a commit that referenced this pull request Jan 6, 2024
@frenck frenck mentioned this pull request Jan 6, 2024
@timmo001 timmo001 deleted the systembridge-fix-play-pause branch January 6, 2024 16:34
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Jan 6, 2024
…to v2024.1.2 (#294)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.1` -> `2024.1.2` |

---

### Release Notes

<details>
<summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary>

### [`v2024.1.2`](https://github.com/home-assistant/core/releases/tag/2024.1.2)

[Compare Source](home-assistant/core@2024.1.1...2024.1.2)

-   Fix support for play/pause functionality in System Bridge ([@&#8203;timmo001] - [#&#8203;103423]) ([system_bridge docs])
-   Fix passing correct location id to streamlabs water ([@&#8203;joostlek] - [#&#8203;107291]) ([streamlabswater docs])
-   Fix Shelly missing Gen value for older devices ([@&#8203;thecode] - [#&#8203;107294]) ([shelly docs])
-   enigma2: fix exception when device in deep sleep, fix previous track ([@&#8203;autinerd] - [#&#8203;107296]) ([enigma2 docs])
-   Fix assertion error when unloading ZHA with pollable entities ([@&#8203;dmulcahey] - [#&#8203;107311]) ([zha docs])

[#&#8203;103423]: home-assistant/core#103423

[#&#8203;106970]: home-assistant/core#106970

[#&#8203;107239]: home-assistant/core#107239

[#&#8203;107291]: home-assistant/core#107291

[#&#8203;107294]: home-assistant/core#107294

[#&#8203;107296]: home-assistant/core#107296

[#&#8203;107311]: home-assistant/core#107311

[@&#8203;autinerd]: https://github.com/autinerd

[@&#8203;dmulcahey]: https://github.com/dmulcahey

[@&#8203;frenck]: https://github.com/frenck

[@&#8203;joostlek]: https://github.com/joostlek

[@&#8203;thecode]: https://github.com/thecode

[@&#8203;timmo001]: https://github.com/timmo001

[enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/

[shelly docs]: https://www.home-assistant.io/integrations/shelly/

[streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/

[system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/

[zha docs]: https://www.home-assistant.io/integrations/zha/

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/294
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants