-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for play/pause functionality in System Bridge #103423
Fix support for play/pause functionality in System Bridge #103423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes would disable the config. Is it not a better way to enable both entries via a config. Another way is to add the feature play if pause or stop is enabled and start is not enabled.
Not sure what you mean here? Disable what config? |
The values |
These come from the websocket reporting if these are enabled so when no media is active, these features won't be enabled |
941e6a5
to
9b3de66
Compare
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Fix support for play/pause functionality
…to v2024.1.2 (#294) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.1` -> `2024.1.2` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary> ### [`v2024.1.2`](https://github.com/home-assistant/core/releases/tag/2024.1.2) [Compare Source](home-assistant/core@2024.1.1...2024.1.2) - Fix support for play/pause functionality in System Bridge ([@​timmo001] - [#​103423]) ([system_bridge docs]) - Fix passing correct location id to streamlabs water ([@​joostlek] - [#​107291]) ([streamlabswater docs]) - Fix Shelly missing Gen value for older devices ([@​thecode] - [#​107294]) ([shelly docs]) - enigma2: fix exception when device in deep sleep, fix previous track ([@​autinerd] - [#​107296]) ([enigma2 docs]) - Fix assertion error when unloading ZHA with pollable entities ([@​dmulcahey] - [#​107311]) ([zha docs]) [#​103423]: home-assistant/core#103423 [#​106970]: home-assistant/core#106970 [#​107239]: home-assistant/core#107239 [#​107291]: home-assistant/core#107291 [#​107294]: home-assistant/core#107294 [#​107296]: home-assistant/core#107296 [#​107311]: home-assistant/core#107311 [@​autinerd]: https://github.com/autinerd [@​dmulcahey]: https://github.com/dmulcahey [@​frenck]: https://github.com/frenck [@​joostlek]: https://github.com/joostlek [@​thecode]: https://github.com/thecode [@​timmo001]: https://github.com/timmo001 [enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/ [shelly docs]: https://www.home-assistant.io/integrations/shelly/ [streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/ [system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/ [zha docs]: https://www.home-assistant.io/integrations/zha/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/294 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Proposed change
Fixes use of play/pause service for System Bridge media player.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: