Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enigma2: fix exception when device in deep sleep, fix previous track #107296

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

autinerd
Copy link
Contributor

@autinerd autinerd commented Jan 5, 2024

Proposed change

Fixes throwing exceptions when device is in deep sleep and that the "previous track" doesn't work.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@autinerd autinerd changed the title enigma2: fix exception when device in deep sleep and previous track enigma2: fix exception when device in deep sleep, fix previous track Jan 5, 2024
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

Maybe you could add some tests to the integration

@jpbede jpbede merged commit 9b1a8a1 into home-assistant:dev Jan 6, 2024
18 checks passed
@jpbede jpbede added this to the 2024.1.2 milestone Jan 6, 2024
@autinerd autinerd deleted the enigma2-2024-002 branch January 6, 2024 10:32
@autinerd
Copy link
Contributor Author

autinerd commented Jan 6, 2024

Yes, I want to do that, in addition to getting the config flow approved 😅

frenck pushed a commit that referenced this pull request Jan 6, 2024
…107296)

enigma2: fix exception when device in deep sleep; previous track
@frenck frenck mentioned this pull request Jan 6, 2024
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Jan 6, 2024
…to v2024.1.2 (#294)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.1` -> `2024.1.2` |

---

### Release Notes

<details>
<summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary>

### [`v2024.1.2`](https://github.com/home-assistant/core/releases/tag/2024.1.2)

[Compare Source](home-assistant/core@2024.1.1...2024.1.2)

-   Fix support for play/pause functionality in System Bridge ([@&#8203;timmo001] - [#&#8203;103423]) ([system_bridge docs])
-   Fix passing correct location id to streamlabs water ([@&#8203;joostlek] - [#&#8203;107291]) ([streamlabswater docs])
-   Fix Shelly missing Gen value for older devices ([@&#8203;thecode] - [#&#8203;107294]) ([shelly docs])
-   enigma2: fix exception when device in deep sleep, fix previous track ([@&#8203;autinerd] - [#&#8203;107296]) ([enigma2 docs])
-   Fix assertion error when unloading ZHA with pollable entities ([@&#8203;dmulcahey] - [#&#8203;107311]) ([zha docs])

[#&#8203;103423]: home-assistant/core#103423

[#&#8203;106970]: home-assistant/core#106970

[#&#8203;107239]: home-assistant/core#107239

[#&#8203;107291]: home-assistant/core#107291

[#&#8203;107294]: home-assistant/core#107294

[#&#8203;107296]: home-assistant/core#107296

[#&#8203;107311]: home-assistant/core#107311

[@&#8203;autinerd]: https://github.com/autinerd

[@&#8203;dmulcahey]: https://github.com/dmulcahey

[@&#8203;frenck]: https://github.com/frenck

[@&#8203;joostlek]: https://github.com/joostlek

[@&#8203;thecode]: https://github.com/thecode

[@&#8203;timmo001]: https://github.com/timmo001

[enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/

[shelly docs]: https://www.home-assistant.io/integrations/shelly/

[streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/

[system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/

[zha docs]: https://www.home-assistant.io/integrations/zha/

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/294
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants