Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle preset change errors in ViCare integration #103992

Merged
merged 12 commits into from Nov 27, 2023

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Nov 14, 2023

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/vicare/climate.py Outdated Show resolved Hide resolved
homeassistant/components/vicare/climate.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 15, 2023 12:34
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@CFenner CFenner marked this pull request as ready for review November 16, 2023 08:28
@edenhaus edenhaus marked this pull request as draft November 24, 2023 17:18
@edenhaus edenhaus self-assigned this Nov 24, 2023
@CFenner CFenner marked this pull request as ready for review November 24, 2023 19:47
homeassistant/components/vicare/climate.py Outdated Show resolved Hide resolved
homeassistant/components/vicare/climate.py Outdated Show resolved Hide resolved
homeassistant/components/vicare/climate.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 25, 2023 08:17
@CFenner CFenner marked this pull request as ready for review November 25, 2023 19:54
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CFenner 👍

@edenhaus edenhaus changed the title Handle errors in preset change in ViCare integration Handle preset change errors in ViCare integration Nov 27, 2023
@edenhaus edenhaus merged commit a5934e9 into home-assistant:dev Nov 27, 2023
23 checks passed
@CFenner CFenner deleted the patch-2 branch November 27, 2023 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants