Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle preset change errors in ViCare integration #103992

Merged
merged 12 commits into from
Nov 27, 2023
Merged

Handle preset change errors in ViCare integration #103992

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
670eace
Update climate.py
CFenner Nov 14, 2023
049f5c6
reset comments
CFenner Nov 15, 2023
74a9157
raise ValueError
CFenner Nov 15, 2023
ce144f2
Merge branch 'dev' into patch-2
CFenner Nov 15, 2023
1aeabcb
Merge branch 'dev' into patch-2
CFenner Nov 16, 2023
bb8aa0a
use translable exception
CFenner Nov 24, 2023
579ce7a
Update strings.json
CFenner Nov 24, 2023
77b87cf
Merge branch 'dev' into patch-2
CFenner Nov 25, 2023
0764f3e
Update strings.json
CFenner Nov 25, 2023
d72acb3
apply suggestion
CFenner Nov 25, 2023
e8a127c
use ServiceValidationError
CFenner Nov 25, 2023
5dcd4c8
Merge branch 'dev' into patch-2
CFenner Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 12 additions & 5 deletions homeassistant/components/vicare/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,16 +298,23 @@ def set_preset_mode(self, preset_mode: str) -> None:
f"Cannot set invalid vicare program: {preset_mode}/{vicare_program}"
edenhaus marked this conversation as resolved.
Show resolved Hide resolved
)

_LOGGER.debug("Setting preset to %s / %s", preset_mode, vicare_program)
_LOGGER.debug("Current preset %s", self._current_program)
if self._current_program != VICARE_PROGRAM_NORMAL:
# We can't deactivate "normal"
# We can't deactivate "normal" or "reduced"
edenhaus marked this conversation as resolved.
Show resolved Hide resolved
_LOGGER.debug("deactivating %s", self._current_program)
try:
self._circuit.deactivateProgram(self._current_program)
except PyViCareCommandError:
_LOGGER.debug("Unable to deactivate program %s", self._current_program)
_LOGGER.error("Unable to deactivate program %s", self._current_program)

_LOGGER.debug("Setting preset to %s / %s", preset_mode, vicare_program)
if vicare_program != VICARE_PROGRAM_NORMAL:
CFenner marked this conversation as resolved.
Show resolved Hide resolved
# And we can't explicitly activate normal, either
self._circuit.activateProgram(vicare_program)
# And we can't explicitly activate "normal" or "reduced", either
_LOGGER.debug("activating %s", vicare_program)
try:
self._circuit.activateProgram(vicare_program)
except PyViCareCommandError:
_LOGGER.error("Unable to activate program %s", vicare_program)

@property
def extra_state_attributes(self):
Expand Down