New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add To-do due date and description fields #104128
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
From discussion, we do want datetime in the UI. Will mark as draft and have a separate feature flag for date vs datetime. |
38bfa71
to
6b2c83a
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a merge conflict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Should this wait for a frontend PR? |
I was assuming that it should in case we need any changes, though it does work fine as standalone service calls without UI right now. |
We've decided to merge this before the frontend work is done. We'll work on the UI design and frontend separately in the next release cycle. Please solve the merge conflict and then go ahead and merge. Thanks! |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
1a33b3a
to
95a55af
Compare
I've rebased and fixed some issues after the rebase. When CI passes we can merge. |
Proposed change
Add To-do due date/time and description fields, with a separate feature entity for each
SET_DUE_DATE_ON_ITEM
,SET_DUE_DATETIME_ON_ITEM
, andSET_DESCRIPTION_ON_ITEM
.These fields will be supported by the following integrations:
Example local to-do output:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: