Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add due date and description fields to Todoist To-do entity #104655

Merged
merged 6 commits into from Nov 30, 2023

Conversation

allenporter
Copy link
Contributor

Proposed change

Add Todoist Due date and description fields.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter allenporter marked this pull request as draft November 28, 2023 16:32
@allenporter allenporter marked this pull request as ready for review November 28, 2023 16:32
@MartinHjelmare MartinHjelmare changed the title Add due date and description fields to Todoist To-do entity. Add due date and description fields to Todoist To-do entity Nov 28, 2023
homeassistant/components/todoist/todo.py Outdated Show resolved Hide resolved
homeassistant/components/todoist/todo.py Outdated Show resolved Hide resolved
tests/components/todoist/test_todo.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft November 28, 2023 22:03
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@allenporter
Copy link
Contributor Author

Merged to handle the due_datetime change. Thank you for handling the follow through on that fix.

@MartinHjelmare
Copy link
Member

There are som test failures.

@MartinHjelmare MartinHjelmare marked this pull request as draft November 29, 2023 21:40
@allenporter allenporter marked this pull request as ready for review November 30, 2023 04:15
@allenporter
Copy link
Contributor Author

There are som test failures.

Sorry about that, fixed. Not sure what I messed up there. Passes now.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 64a6a6a into home-assistant:dev Nov 30, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
@MartinHjelmare MartinHjelmare added this to the 2023.12.0 milestone Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants