Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiounifi to v66 #104336

Merged
merged 1 commit into from Nov 22, 2023
Merged

Bump aiounifi to v66 #104336

merged 1 commit into from Nov 22, 2023

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Nov 21, 2023

Breaking change

Proposed change

Kane610/aiounifi@v65...v66
Follows up on brdracos comment about logging errors (#103346)
Changed tests to not be affected by only counting expected calls rather than the complete amount of calls made during init.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Nov 21, 2023

Also be sure to checkout #103814 in case you need to handle BaseException differently

@Kane610
Copy link
Member Author

Kane610 commented Nov 22, 2023

Also be sure to checkout #103814 in case you need to handle BaseException differently

More things to think about, thanks! ;)

@Kane610 Kane610 merged commit f1fd8a0 into home-assistant:dev Nov 22, 2023
53 checks passed
@Kane610 Kane610 deleted the unifi-bump_to_v66 branch November 22, 2023 06:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants