Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BLE connection state unsubscribe workaround from ESPHome #104674

Merged
merged 1 commit into from Nov 28, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 28, 2023

Proposed change

aioesphomeapi now has explicit coverage to ensure calling the unsubscribe function after the connection drops is safe and will not raise anymore

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

aioesphomeapi now has explict coverage to ensure calling
the unsubscribe function after the connection drops is safe
and will not raise anymore
@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, @kbx81, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco mentioned this pull request Nov 28, 2023
20 tasks
@bdraco
Copy link
Member Author

bdraco commented Nov 28, 2023

Looks good at shutdown as well

2023-11-28 11:45:30.425 DEBUG (MainThread) [aioesphomeapi.connection] fargarageratgdo @ 192.168.107.50: Sending DisconnectRequest:
2023-11-28 11:45:30.425 DEBUG (MainThread) [aioesphomeapi._frame_helper.base] fargarageratgdo @ 192.168.107.50: Sending frame: [000005]                                                     
2023-11-28 11:45:30.425 DEBUG (MainThread) [aioesphomeapi.connection] kauf-bulb-7d4892 @ 192.168.106.95: Sending DisconnectRequest:
2023-11-28 11:45:30.425 DEBUG (MainThread) [aioesphomeapi._frame_helper.base] kauf-bulb-7d4892 @ 192.168.106.95: Sending frame: [010014862693021abec44bc721541d76d1985b8fdeeb83]
2023-11-28 11:45:30.426 DEBUG (MainThread) [homeassistant.components.esphome.bluetooth.client] upstairsdeskgli89proxy [c8:f0:9e:d1:32:68]: LI0 - 98:1B:B5:71:40:6D: ESP device disconnected                 
2023-11-28 11:45:30.426 DEBUG (MainThread) [homeassistant.components.esphome.bluetooth.client] upstairsdeskgli89proxy [c8:f0:9e:d1:32:68]: LI0 - 98:1B:B5:71:40:6D: BLE device disconnected
2023-11-28 11:45:30.426 DEBUG (MainThread) [aioesphomeapi.connection] upstairsdeskgli89proxy @ 192.168.106.55: Sending DisconnectRequest:                                 
2023-11-28 11:45:30.426 DEBUG (MainThread) [aioesphomeapi._frame_helper.base] upstairsdeskgli89proxy @ 192.168.106.55: Sending frame: [000005]
2023-11-28 11:45:30.426 DEBUG (MainThread) [aioesphomeapi.connection] laundrygli89proxy @ 192.168.107.142: Sending DisconnectRequest:
2023-11-28 11:45:30.426 DEBUG (MainThread) [aioesphomeapi._frame_helper.base] laundrygli89proxy @ 192.168.107.142: Sending frame: [000005]                                          
2023-11-28 11:45:30.426 DEBUG (MainThread) [aioesphomeapi.connection] rackgli89proxy @ 192.168.107.220: Sending DisconnectRequest:                                 

👍

@bdraco bdraco marked this pull request as ready for review November 28, 2023 21:47
@MartinHjelmare MartinHjelmare merged commit de3b608 into dev Nov 28, 2023
23 checks passed
@MartinHjelmare MartinHjelmare deleted the esphome_ble_workarounds branch November 28, 2023 22:38
@bdraco
Copy link
Member Author

bdraco commented Nov 28, 2023

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants