New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Lyric HVAC mode reset on temperature change #104910
Fix Lyric HVAC mode reset on temperature change #104910
Conversation
Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
d29ae2b
to
4d5598c
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thnx @apt-itude 👍
* Fix Lyric HVAC mode reset on temperature change * Reduce code duplication * Revert additional bugfix Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> --------- Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
Proposed change
When my T10 thermostat is in "Auto" mode, changing the temperature causes it to be reset back to it's previous mode (e.g. "Heat").
This is because the
async_set_temperature
method passes themode=HVAC_MODES[device.changeableValues.heatCoolMode]
option to the_update_thermostat
call. When the thermostat is in "Auto" mode, theheatCoolMode
shows either "Heat" or "Cool" depending on the actual heating or cooling state. E.g.Passing this back in as the mode causes the device to be reset back to "Heat" mode.
This checks if the device is in "Auto" mode first, and if so, omits the
mode
parameter when updating the thermostat.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: