Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lyric HVAC mode reset on temperature change #104910

Merged
merged 3 commits into from Dec 3, 2023
Merged

Fix Lyric HVAC mode reset on temperature change #104910

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05f13f3
Fix Lyric HVAC mode reset on temperature change
apt-itude Dec 2, 2023
4d5598c
Reduce code duplication
apt-itude Dec 3, 2023
3ce9500
Revert additional bugfix
apt-itude Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion homeassistant/components/lyric/climate.py
View file
Open in desktop
Expand Up @@ -324,14 +324,23 @@ async def async_set_temperature(self, **kwargs: Any) -> None:
"Could not find target_temp_low and/or target_temp_high in"
" arguments"
)

# If the device supports "Auto" mode, don't pass the mode when setting the
# temperature
mode = (
None
if device.changeableValues.mode == LYRIC_HVAC_MODE_HEAT_COOL
else device.changeableValues.heatCoolMode
apt-itude marked this conversation as resolved.
Show resolved Hide resolved
)

_LOGGER.debug("Set temperature: %s - %s", target_temp_low, target_temp_high)
try:
await self._update_thermostat(
self.location,
device,
coolSetpoint=target_temp_high,
heatSetpoint=target_temp_low,
mode=HVAC_MODES[device.changeableValues.heatCoolMode],
mode=mode,
apt-itude marked this conversation as resolved.
Show resolved Hide resolved
)
except LYRIC_EXCEPTIONS as exception:
_LOGGER.error(exception)
Expand Down