-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rollback on exception that needs rollback in SQL #104948
Conversation
Hey there @dougiteixeira, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@bdraco do you think this would be sufficient for dealing with the issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. It could use a test to make sure that if it fails, it can be reused though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test works, but it would be better if it was more end to end and actually generate the sql alchemy exception instead of simulating it
@bdraco what do you think of the rewrite. Not testing the specific issue but creates an operational error and then continue. |
Thanks @gjohansson-ST |
Thanks 👍 |
Proposed change
Adds a rollback if necessary (from error message)
See #95661 for context
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: