Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rollback on exception that needs rollback in SQL #104948

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Add rollback on exception that needs rollback in SQL #104948

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d59ed4
Add rollback on exception that needs rollback
gjohansson-ST Dec 3, 2023
517ece6
remove if
gjohansson-ST Dec 3, 2023
0e87966
Add test
gjohansson-ST Dec 3, 2023
2381d12
Rewrite test
gjohansson-ST Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions homeassistant/components/sql/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,8 @@
self._query,
redact_credentials(str(err)),
)
sess.rollback()
sess.close()

Check warning on line 366 in homeassistant/components/sql/sensor.py

View check run for this annotation

Codecov / codecov/patch

homeassistant/components/sql/sensor.py#L366 

Added line #L366 was not covered by tests
return

for res in result.mappings():
Expand Down