-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to inherit EntityDescription in frozen and mutable dataclasses #105211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
reviewed
Dec 7, 2023
emontnemery
commented
Dec 7, 2023
bdraco
reviewed
Dec 7, 2023
bdraco
reviewed
Dec 7, 2023
This looks good Should we do a blog post about freezing entity description |
Merged
5 tasks
Blog post added 👍 |
Pushing the latest to my production now |
bdraco
approved these changes
Dec 11, 2023
All good on production, nothing obvious blew up |
frenck
approved these changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Make it possible to inherit
EntityDescription
in both frozen and mutable dataclassesBackground and rationale
PR #100601 explores caching of entity properties. A major issue is that although not useful, entity descriptions are mutable, meaning we may miss changes if an integration mutates its entity descriptions.
If we make
EntityDescription
a frozen dataclass the problem is solved for all core integrations, but this would be a hard breaking change for custom integrations because it's a runtime error to derive a mutable dataclass from a frozen dataclass.More details here: #100601 (comment)
Solution
Make
EntityDescription
behave as a dataclass, but allow it to be the base class for both frozen and mutable dataclasses. This is achieved with a metaclassFrozenOrThawed
. Thanks to PEP 681 type checkers, including MyPy, keep working.The
FrozenOrThawed
metaclass will look for the class argumentfrozen_or_thawed
:@dataclass
.In follow-up PRs:
EntityDescription
are not frozenType of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: