Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring UniFi clients with old unique id #105691

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Dec 13, 2023

Breaking change

Proposed change

Restoring clients used the old unique id. With #104390 unique ids where changed but this position was missed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 2023.12.3 milestone Dec 13, 2023
@Kane610 Kane610 changed the title Fix restoring UniFi clients with bad unique id Fix restoring UniFi clients with old unique id Dec 13, 2023
@Kane610 Kane610 merged commit 7084889 into home-assistant:dev Dec 13, 2023
23 checks passed
@Kane610
Copy link
Member Author

Kane610 commented Dec 13, 2023

Thanks @bdraco 🎉

@Kane610 Kane610 deleted the unifi-fix_restoring_clients_after_changing_unique_id branch December 13, 2023 21:35
frenck pushed a commit that referenced this pull request Dec 14, 2023
Fix restoring UniFi clients with bad unique id
@frenck frenck mentioned this pull request Dec 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unifi integration marks device_tracker as unavailable if not online at time of homeassistant restart
3 participants