Remove unused option flow from blink #106735
Conversation
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: blink
small-pr
|
Hey there @fronzbot, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
No one has complained yet, but that doesn't mean it's not killing batteries. |
|
@mkmer - 30s scan interval won't kill batteries since it just polls the servers and then the sync module, which is wall powered. The battery-operated cameras are "smart" in that they are the ones who initiate a transaction with the sync module if an event has occurred (the exception being a user-triggered image or video request). 30s is on the "most aggressive" side of the recommended refresh rate (for API rate limiting reasons), but it was the default setting for this integration prior to having the gui-based config options (back in the wild west days of HA where it was just yaml as far as the eye could see 😄). With that said, I think updating to 5 minutes is good as long as we note that in the documentation. |
|
@mkmer hmm, is there a reason we can't maintain the option flow though? One use case for wanting a global update of the refresh rate (rather than disabling polling and manually triggering) is for motion detection. It's not perfect, due to the delay, but not having the ability to adjust that to lower values might be a bad change to introduce |
|
To be clear, with the coordinator it's enough to update one entity via the service call to make the coordinator refresh and in turn update all entities that received a new state from the coordinator. |
|
@fronzbot I believe an adjustable scan interval is no longer allowed, and since I broke it, might as well take it out. |
|
I think we should go with 30 seconds (leave it as it currently is). It has been at 30 seconds for 2 months now. If it generates issues with users, take a look at it at that point? |
|
Let's add a breaking change paragraph in the PR description and mention that the scan interval option is removed as it's not allowed to have a config option for scan interval and it's been broken since November without issue reports. Also add a link to the docs page for custom polling. https://www.home-assistant.io/common-tasks/general/#defining-a-custom-polling-interval |
|
It's possible the 30 second update has caught up with us. Lot's of 406 errors from Blink servers in the last few days. |
|
Yes, PR is clear to merge. |
* Remove unused option flow * remove update listener * adjust scan_interval to original default * default scn interval back to 30s
Breaking change
Remove option flow for scan_interval. Adjustable scan interval is no longer allowed and the option has had no effect on the integration since 2023.11. If an alternate polling rate is desired, use https://www.home-assistant.io/common-tasks/general/#defining-a-custom-polling-interval. Updating one entity in a blink configuration will update all entities in each blink configuration.
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: