New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rainforest_raven typing #107309
Fix rainforest_raven typing #107309
Conversation
Hey there @cottsay, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have been caught by the pre-commit checks?
Not necessarily. It's not an actual bug but rather just a typing issue. I only found it as I'm testing an experimental versions of Mypy. |
Understood, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @cdce8p 👍
Proposed change
Make
message_key
a required key.It's present on all EntityDescriptions and can't be
None
for the data lookup here:core/homeassistant/components/rainforest_raven/sensor.py
Lines 141 to 144 in 2b43271
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: