Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zm-py version to v0.5.3 for zoneminder #107331

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

nabbi
Copy link
Contributor

@nabbi nabbi commented Jan 6, 2024

ZoneMinder 1.36 released a couple of years ago with breaking API changes, most HA deployments running the newer ZM version have limited HA integration as a result of zm-py package being dormant.

This updated zm-py python dependency incorporated bug fixes and refactored python wrapper against the latest ZM API

Users should now see:

  • ZM Run State report correctly (vs unknown)
  • ZM monitors in Alarm state report correctly (vs PreAlarm)
  • ZM API change exceptions caught (vs crashed)

Proposed change

Version bump zm-py package from v0.5.2 to v0.5.3

This release repairs the known integration issues with ZM version 1.36+

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

https://github.com/rohankapoorcom/zm-py/releases/tag/v0.5.3

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Nic Boet <nic@boet.cc>
@home-assistant
Copy link

home-assistant bot commented Jan 6, 2024

Hey there @rohankapoorcom, mind taking a look at this pull request as it has been labeled with an integration (zoneminder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zoneminder can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zoneminder Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@nabbi nabbi marked this pull request as ready for review January 6, 2024 01:49
Copy link
Member

@rohankapoorcom rohankapoorcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nabbi!

@rohankapoorcom rohankapoorcom changed the title zm-py version bump package in zoneminder Bump zm-py version to v0.5.3 for zoneminder Jan 6, 2024
@rohankapoorcom rohankapoorcom merged commit 6201e81 into home-assistant:dev Jan 6, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
@frenck frenck added this to the 2024.1.3 milestone Jan 12, 2024
@frenck
Copy link
Member

frenck commented Jan 12, 2024

Added to the milestone in order to merge #107519 cleanly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants