Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swiss public transport initial data for attributes #107452

Merged
merged 1 commit into from Jan 7, 2024

Conversation

miaucl
Copy link
Contributor

@miaucl miaucl commented Jan 7, 2024

Proposed change

Fill attribute data at startup, instead of only after the first update triggered by the coordinator.

Discord dev_core: When using a coordinator using cloud_polling to load data for a platform and the platform treats its chunk of data provided by to coordinator in _handle_coordinator_update, I see following behaviour, that the platform gets setup quite fast, but the first time any data is provided to that platform through the coordinator, it takes 90s (update_interval). Even though using async_config_entry_first_refresh at the beginning. Is that normal or is there a way to trigger that faster? I find it a bit strange that one has to wait for 90s to get data after the integration config flow has ended.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 7, 2024

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (swiss_public_transport) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of swiss_public_transport can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign swiss_public_transport Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@miaucl miaucl marked this pull request as ready for review January 7, 2024 13:02
@miaucl miaucl requested a review from fabaff as a code owner January 7, 2024 13:02
@home-assistant home-assistant bot marked this pull request as draft January 7, 2024 13:23
@home-assistant
Copy link

home-assistant bot commented Jan 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MartinHjelmare MartinHjelmare changed the title faster initial data for attributes Fix Swiss public transport initial data for attributes Jan 7, 2024
@miaucl miaucl marked this pull request as ready for review January 7, 2024 13:37
@MartinHjelmare MartinHjelmare added this to the 2024.1.3 milestone Jan 7, 2024
@MartinHjelmare MartinHjelmare merged commit 3139e92 into home-assistant:dev Jan 7, 2024
23 checks passed
@miaucl miaucl deleted the spt_faster_initial_data branch January 7, 2024 16:54
mkmer pushed a commit to mkmer/HomeAssistant_Core that referenced this pull request Jan 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants