Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioshelly to 7.1.0 #107593

Merged
merged 1 commit into from Jan 11, 2024
Merged

Bump aioshelly to 7.1.0 #107593

merged 1 commit into from Jan 11, 2024

Conversation

thecode
Copy link
Member

@thecode thecode commented Jan 8, 2024

Proposed change

Bump aioshelly to 7.1.0:
GitHub Diff: home-assistant-libs/aioshelly@7.0.0...7.1.0
Release notes: https://github.com/home-assistant-libs/aioshelly/releases/tag/7.1.0

This version lower the minimum firmware requirement for most Gen1 devices to 1.9.0 and fix concurrent call to receive which may hang the Home Assistant instance.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 8, 2024

Hey there @balloob, @bieniu, @chemelli74, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bieniu
Copy link
Member

bieniu commented Jan 8, 2024

I will use a new aioshelly on my prod system and give approval tomorrow if everything works well.

Copy link
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My prod system has been working fine with this change since yesterday. Thanks 👍

@bdraco
Copy link
Member

bdraco commented Jan 9, 2024

I've been running the websocket change for a while. I'll throw this on both of my primary production now

@bdraco
Copy link
Member

bdraco commented Jan 9, 2024

Restarted with this. Everything looks ok on both

@bdraco
Copy link
Member

bdraco commented Jan 11, 2024

This has been running for a few days without issue 👍

@bdraco bdraco merged commit 28b5104 into home-assistant:dev Jan 11, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
@thecode thecode deleted the bump-aioshelly branch February 25, 2024 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shelly: aioshelly (Concurrent call to receive() is not allowed")
6 participants