Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shelly Gen1 minimum firmware versions #30732

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

thecode
Copy link
Member

@thecode thecode commented Jan 8, 2024

Proposed change

Update Shelly Gen1 minimum firmware versions

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 8, 2024
@home-assistant

This comment was marked as resolved.

@thecode
Copy link
Member Author

thecode commented Jan 8, 2024

Note to reviewers: Due to a device which does not meet the minimum firmware requirement we lowered the minimum firmware requirement for Gen1 devices, this is why we need to update the docs for current branch together with the core PR

@thecode thecode removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 8, 2024
bieniu
bieniu previously approved these changes Jan 8, 2024
@kblin
Copy link

kblin commented Jan 8, 2024

I'm not sure the gen2 version requirement is good either. I certainly have a plus plug S v1 that stubbornly claims that 0.12.99 is the latest firmware available.

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Jan 10, 2024
@c0ffeeca7
Copy link
Contributor

I'm not sure the gen2 version requirement is good either. I certainly have a plus plug S v1 that stubbornly claims that 0.12.99 is the latest firmware available.

@thecode: does this affect this PR, or would this be a topic for another PR?

@kblin
Copy link

kblin commented Jan 11, 2024

I think you're good to go. My plug did manage to grab a new firmware after a factory reset and works as described in this PR now.
Sorry for the noise.

@thecode
Copy link
Member Author

thecode commented Jan 11, 2024

Thanks @bdraco

@thecode
Copy link
Member Author

thecode commented Jan 11, 2024

and @c0ffeeca7 for the typo fix 👍

@thecode thecode merged commit cf652d7 into home-assistant:current Jan 11, 2024
6 checks passed
@home-assistant home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label Jan 11, 2024
@thecode thecode deleted the shelly-gen1-fw-ver branch January 11, 2024 09:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants