Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tado unique mobile device dispatcher #107631

Merged

Conversation

erwindouna
Copy link
Contributor

@erwindouna erwindouna commented Jan 9, 2024

Breaking change

Proposed change

Add a unique dispatcher per mobile device, instead of running it on the generic dispatcher. This caused issues when users have multiple homes and multiple installations running on one HA installation.
Having an unique dispatcher per mobile device, based on the underlying home ID, will prevent a too generic dispatcher for all mobile devices. The generic dispatcher would load only the mobile devices known per home, and missed the mobile devices linked to a different entry.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 9, 2024

Hey there @michaelarnauts, @chiefdragon, mind taking a look at this pull request as it has been labeled with an integration (tado) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tado can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tado Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@erwindouna erwindouna marked this pull request as ready for review January 9, 2024 08:00
@erwindouna erwindouna marked this pull request as draft January 9, 2024 08:01
@erwindouna erwindouna marked this pull request as ready for review January 9, 2024 08:17
@erwindouna erwindouna changed the title Tado ddd unique mobile device dispatcher Tado add unique mobile device dispatcher Jan 9, 2024
homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/tado/__init__.py Show resolved Hide resolved
homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 9, 2024 13:26
@home-assistant
Copy link

home-assistant bot commented Jan 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@erwindouna erwindouna marked this pull request as ready for review January 9, 2024 13:53
homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/tado/__init__.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 9, 2024 14:02
erwindouna and others added 3 commits January 9, 2024 15:03
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@erwindouna erwindouna marked this pull request as ready for review January 9, 2024 14:04
@MartinHjelmare MartinHjelmare added this to the 2024.1.3 milestone Jan 9, 2024
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michaelarnauts michaelarnauts removed their assignment Jan 10, 2024
@erwindouna
Copy link
Contributor Author

@MartinHjelmare It can be merged now. :)

@MartinHjelmare MartinHjelmare changed the title Tado add unique mobile device dispatcher Fix Tado unique mobile device dispatcher Jan 10, 2024
@MartinHjelmare MartinHjelmare merged commit 15e3af7 into home-assistant:dev Jan 10, 2024
23 checks passed
@erwindouna erwindouna deleted the tado-multiple-homes-device-tracker branch January 10, 2024 11:09
catsmanac pushed a commit to catsmanac/ha-core-dev that referenced this pull request Jan 10, 2024
* Add unique home ID device dispatch

* Adding fixture for new setup

* Minor refactor work

* Add check for unlinked to different homes

* If the interface returns an error

* Proper error handling

* Feedback fixes

* Comments for error in client

* Typo

* Update homeassistant/components/tado/__init__.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update homeassistant/components/tado/__init__.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update devices fix standard

* Dispatch out of loop

* Update dispatcher

* Clean up

---------

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
enioo22 pushed a commit to enioo22/bzutech-core that referenced this pull request Jan 10, 2024
* Add unique home ID device dispatch

* Adding fixture for new setup

* Minor refactor work

* Add check for unlinked to different homes

* If the interface returns an error

* Proper error handling

* Feedback fixes

* Comments for error in client

* Typo

* Update homeassistant/components/tado/__init__.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update homeassistant/components/tado/__init__.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update devices fix standard

* Dispatch out of loop

* Update dispatcher

* Clean up

---------

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tado climate device showing "auto" When I restart Home assistant tado integration couldn't set up
4 participants