Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tado unique mobile device dispatcher #107631

Merged
merged 15 commits into from
Jan 10, 2024
Merged

Fix Tado unique mobile device dispatcher #107631

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
139a647
Add unique home ID device dispatch
erwindouna Jan 9, 2024
5faf7ad
Adding fixture for new setup
erwindouna Jan 9, 2024
22a502b
Minor refactor work
erwindouna Jan 9, 2024
c5109c7
Add check for unlinked to different homes
erwindouna Jan 9, 2024
9efc0a0
If the interface returns an error
erwindouna Jan 9, 2024
7ab2a6a
Proper error handling
erwindouna Jan 9, 2024
64f483f
Feedback fixes
erwindouna Jan 9, 2024
83cda3d
Comments for error in client
erwindouna Jan 9, 2024
3801459
Typo
erwindouna Jan 9, 2024
9360cfc
Update homeassistant/components/tado/__init__.py
erwindouna Jan 9, 2024
ffc6724
Update homeassistant/components/tado/__init__.py
erwindouna Jan 9, 2024
c52ca78
Update devices fix standard
erwindouna Jan 9, 2024
1e1c898
Dispatch out of loop
erwindouna Jan 9, 2024
c177dee
Update dispatcher
erwindouna Jan 9, 2024
ec1a4f2
Clean up
MartinHjelmare Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions homeassistant/components/tado/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ def __init__(self, hass, username, password, fallback):
self.tado = None
self.zones = None
self.devices = None
self.mobile_devices = None
self.data = {
"device": {},
"mobile_device": {},
Expand All @@ -182,7 +181,6 @@ def setup(self):
# Load zones and devices
self.zones = self.tado.get_zones()
self.devices = self.tado.get_devices()
self.mobile_devices = self.tado.get_mobile_devices()
tado_home = self.tado.get_me()["homes"][0]
self.home_id = tado_home["id"]
self.home_name = tado_home["name"]
Expand All @@ -208,9 +206,7 @@ def update_mobile_devices(self) -> None:
return

if len(mobile_devices) == 0:
MartinHjelmare marked this conversation as resolved.
Show resolved Hide resolved
_LOGGER.warning(
"No linked mobile devices found for home ID %s", self.home_id
)
_LOGGER.debug("No linked mobile devices found for home ID %s", self.home_id)
return

if "errors" in mobile_devices and len(mobile_devices["errors"]) > 0:
erwindouna marked this conversation as resolved.
Show resolved Hide resolved
erwindouna marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -230,9 +226,7 @@ def update_mobile_devices(self) -> None:
)
dispatcher_send(
MartinHjelmare marked this conversation as resolved.
Show resolved Hide resolved
self.hass,
SIGNAL_TADO_MOBILE_DEVICE_UPDATE_RECEIVED.format(
self.home_id, mobile_device["id"]
),
SIGNAL_TADO_MOBILE_DEVICE_UPDATE_RECEIVED.format(self.home_id),
)

dispatcher_send(self.hass, SIGNAL_TADO_MOBILE_DEVICES_UPDATE)
Expand All @@ -246,7 +240,7 @@ def update_devices(self):
return

if len(devices) == 0:
MartinHjelmare marked this conversation as resolved.
Show resolved Hide resolved
_LOGGER.warning("No linked devices found for home ID %s", self.home_id)
_LOGGER.debug("No linked devices found for home ID %s", self.home_id)
return

if "errors" in devices and len(devices["errors"]) > 0:
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/tado/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
DOMAIN = "tado"

SIGNAL_TADO_UPDATE_RECEIVED = "tado_update_received_{}_{}_{}"
SIGNAL_TADO_MOBILE_DEVICE_UPDATE_RECEIVED = "tado_mobile_device_update_received_{}_{}"
SIGNAL_TADO_MOBILE_DEVICE_UPDATE_RECEIVED = "tado_mobile_device_update_received_{}"
SIGNAL_TADO_MOBILE_DEVICES_UPDATE = "tao_mobile_devices_update"
UNIQUE_ID = "unique_id"

Expand Down
4 changes: 1 addition & 3 deletions homeassistant/components/tado/device_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,7 @@ async def async_added_to_hass(self) -> None:
self.async_on_remove(
async_dispatcher_connect(
self.hass,
SIGNAL_TADO_MOBILE_DEVICE_UPDATE_RECEIVED.format(
self._tado.home_id, self._device_id
),
SIGNAL_TADO_MOBILE_DEVICE_UPDATE_RECEIVED.format(self._tado.home_id),
self.on_demand_update,
)
)
Expand Down
Loading